Skip to content

Conversation

@bnbarham
Copy link
Contributor

As in most LLVM updates, OPTION has been modified. Update makeOptions.cpp to take this into account.

As in most LLVM updates, `OPTION` has been modified. Update
`makeOptions.cpp` to take this into account.
@bnbarham bnbarham requested review from artemcm and compnerd August 21, 2024 02:29
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@compnerd
Copy link
Member

@swift-ci please test Linux platform

@compnerd
Copy link
Member

The Windows failure is acceptable - it is failing at testing Swift:

Failed Tests (7):
  Swift(windows-x86_64) :: Frontend/output_determinism_check.swift
  Swift(windows-x86_64) :: IRGen/async/class_resilience.swift
  Swift(windows-x86_64) :: IRGen/async/protocol_resilience.swift
  Swift(windows-x86_64) :: Interop/Cxx/class/method/methods-this-and-indirect-return-irgen-msvc.swift
  Swift(windows-x86_64) :: Interop/Cxx/operators/member-out-of-line-irgen.swift
  Swift-Unit :: Basic/./SwiftBasicTests.exe/FileSystem/MoveFileIfDifferentEmpty
  Swift-Unit :: Basic/./SwiftBasicTests.exe/FileSystem/MoveFileIfDifferentNonEmpty

@bnbarham
Copy link
Contributor Author

I'm just going to merge, the linux failure is infrastructure related and I don't plan on making any other changes to swift-driver in rebranch. I'll just keep an eye on the jobs.

@bnbarham bnbarham merged commit 2cac18a into swiftlang:rebranch Aug 21, 2024
@bnbarham bnbarham deleted the fix-options branch August 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants