Revert "Revert "Update Generic Unix linker selection""#1608
Merged
Conversation
artemcm
approved these changes
May 13, 2024
Member
Author
|
@swift-ci please test |
drodriguez
added a commit
to drodriguez/swift-driver
that referenced
this pull request
May 30, 2024
The spelling of the linker is `-fuse-ld=`, not `--fuse-ld=`, as it can be seen in [1] and as used in the C++ driver in [2]. The code was correct before swiftlang#1545 using `-fuse-ld=`, but was changed to `--fuse-ld=`. The test was testing for the command line containing the same spelling, so it would had never failed, but running the actual command line would had failed. That code was eventually reverted and reverted back in swiftlang#1608. [1]: https://github.com/apple/llvm-project/blob/e33819dff1cbf7a90b0216a4993126cb11440d45/clang/include/clang/Driver/Options.td#L5267 [2]: https://github.com/apple/swift/blob/319f36b01baa082fd2d2640d6e320594752702d0/lib/Driver/UnixToolChains.cpp#L234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1596
Alright ready to re-land this. The issue was that, during the build, the just-built Swift driver would choose the clang from the system instead of the just-built clang that was configured to use
goldorlld. The system clang was configured to use the gnu bfd linker instead of gold or lld. BFD has a known issue with our use of protected symbols and would fail during the Dispatch build with the following error:Telling the just-built driver to use the just-built clang is more consistent with other parts of the build. Technically, for cross-compiling purposes, neither should be in use here, but at least this is more internally consistent.