Don't pass -rpath and -lswiftCore in embedded mode
#1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
These options already aren't passed to the linker when linking statically, we shouldn't pass them in embedded mode either, where everything is linked statically too.
MaxDesiatov
force-pushed
the
maxd/embedded-wasm
branch
from
872ff49 to
a64ead3
Compare
|
@swift-ci test |
MaxDesiatov
changed the title
-rpath and -lswiftCore for embedded Wasm-rpath and -lswiftCore in embedded mode
kateinoigakukun
approved these changes
Jan 1, 2024
|
@swift-ci test windows |
|
Looks like this is pretty much the same thing as #1471 (except this seems to be more complete by alleviating the rpath side of it). |
phausler
approved these changes
Jan 2, 2024
artemcm
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options already aren't passed to the linker when linking statically, we shouldn't pass them in embedded mode either, where everything is linked statically too.
I've been able to reproduce this bug with
wasm32-none-none-wasmtriples, but this should fix possible issues for other embedded triples too.