Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on swift-system #1494

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

neonichu
Copy link
Contributor

This dependency is unused and just unnecessarily complicates things.

This dependency is unused and just unnecessarily complicates things.
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@artemcm
Copy link
Contributor

artemcm commented Nov 29, 2023

apple/swift-tools-support-core#448 @swift-ci please test

There's no cross-repo testing from this repository. :(

@neonichu
Copy link
Contributor Author

@artemcm Not even for the Windows CI?

@artemcm
Copy link
Contributor

artemcm commented Nov 29, 2023

@artemcm Not even for the Windows CI?

No cross-repo testing at all. You can do it by including this PR and others on a PR from the main swift repo.

@neonichu
Copy link
Contributor Author

Looks like it did work for Windows CI? 🤔

@neonichu neonichu merged commit 8395c0f into swiftlang:main Nov 30, 2023
@neonichu neonichu deleted the remove-swift-system branch November 30, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants