-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.10] Revert 'Add missing dependency (#1414)' #1483
Conversation
The llbuild executable is not a dependency of this library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nkcsgexi
@swift-ci test |
Ping, another CI run and then this can go in? |
@neonichu, would be good to get this in before the winter break. |
@kateinoigakukun, please run the CI on this. |
@swift-ci Please test |
Another CI run needed here. @artemcm, looks like this is only held up on 5.10 manager approval, is there someone else who can review? |
@kateinoigakukun, one last CI run and we can get this in. |
@swift-ci test |
Ping @nkcsgexi, ready for review and merge. |
Ping @nkcsgexi, still looking for review here and I figure you are the manager for this repo. |
Ping @artemcm, can we go ahead and get this in? |
@bnbarham, would you review this tiny pull for 5.10? |
@neonichu, this revert of your pull has been stuck for months now, can you review or alert whoever needs to decide? |
Pinging @bnbarham again, can we get this in now? |
Ping @DougGregor, there is no 5.10 release manager listed for this repo on the forum, but maybe it falls under your purview as part of the compiler. This is just a small build cleanup that shouldn't break anything, been working fine in trunk for almost three months now. |
Ping @neonichu, can you notify someone who can get this in? |
Pinging @shahmishal, could you weigh in on this cleanup? |
@shahmishal, if you're preparing a 5.10 patch release, would be good to get this cleanup in. It was merged into trunk six months ago and has had no deleterious effect. |
Cherrypick of #1481
Explanation: The llbuild executable is not a dependency of this library.
Scope: Removes wrongly added llbuild dependency
Issue: None
Risk: low, as less code is built after this
Testing: Passed all CI on trunk
Reviewer: @artemcm