-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't add an autolink-extract job unless actually linking ELF/Wasm objects, matching the original C++ driver #1479
Conversation
…jects, matching the original C++ driver
@bnbarham, need a CI run here. |
@swift-ci test |
Mac and linux CI passed; Windows CI appears to be broken right now, but doesn't matter because this pull changes nothing for Windows. |
@swift-ci test Windows platform |
Windows CI failed again with the same error unrelated to this pull. |
Looks like the Windows CI is passing again on the main compiler repo, one more Windows run here now and it should pass, @artemcm. |
@swift-ci test Windows platform |
@compnerd, the Windows CI is repeatedly failing on this repo when installing ICU, unrelated to these driver pulls:
Does something need to be adjusted on this CI? |
@finagolfin could you please file an issue on apple/swift and include @shahmishal? I think that there were some tweaks that were needed as old revisions were being checked out. |
@swift-ci test Windows platform |
This is needed for swiftlang/swift#69564, which enables building the early swift driver and running tests from the compiler validation suite with it for the first time on the linux CI. Looking at those test failures, I noticed that the Swift toolchain wrongly runs
autolink-extract
on linux when simply compiling object files, which is obviously unused:and which the old C++ driver doesn't:
That's because the old driver checks if it
shouldLink()
before scheduling anautolink-extract
, whereas there's no equivalent check in this repo going back to when theautolink-extract
job was added in c4bf245. That's why @eeckstein had to add this linux-specific hack for these tests he added in #1019, which can now be removed and acts as a regression test.The
autolink-extract
could also be disabled for static libraries, but I kept the behavior the same across both drivers instead.