[Explicit Modules] Handle re-mapped platform versions when specifying SDK-aligned -clang-target on Darwin platforms
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK-aligned `-clang-target` on Darwin platforms Resolves rdar://108288193
|
@swift-ci test |
xymus
reviewed
Jul 6, 2023
| } | ||
| let plannedJobs = try driver.planBuild() | ||
| XCTAssertTrue(plannedJobs.contains { job in | ||
| job.commandLine.contains(subsequence: [.flag("-clang-target"), .flag("arm64-apple-macos10.15")]) |
There was a problem hiding this comment.
Where does the macos10.15 come from here? Does it always pick the SDK version?
There was a problem hiding this comment.
Yes, it comes from the SDKSettings's:
"Version": "10.15",
xymus
reviewed
Jul 6, 2023
| "-sdk", sdkRoot.pathString, | ||
| main.pathString]) | ||
| guard driver.isFrontendArgSupported(.clangTarget) else { | ||
| throw XCTSkip("Skipping: compiler does not support '-clang-target'") | ||
| } | ||
| let plannedJobs = try driver.planBuild() | ||
| XCTAssertTrue(plannedJobs.contains { job in | ||
| job.commandLine.contains(subsequence: [.flag("-clang-target"), .flag("arm64-apple-ios13.0")]) | ||
| job.commandLine.contains(subsequence: [.flag("-clang-target"), .flag("arm64e-apple-ios13.3-macabi")]) |
There was a problem hiding this comment.
Similarly here, are we remapping from the SDK version and not from the driver's -target flag?
There was a problem hiding this comment.
For -clang-target, yes.
First added in #1274.
There was a problem hiding this comment.
Ah interesting, thanks for the clarification!
xymus
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://108288193