Android: look in lib/linux/ for the LLVM sanitizers instead #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jun 8, 2023
…en test, and disable CxxToSwiftToCxx bridging test that now fails on Android Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jun 8, 2023
…en test, and disable CxxToSwiftToCxx bridging test that now fails on Android Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again.
|
@artemcm, let me know what you think. |
artemcm
approved these changes
Jun 12, 2023
|
@artemcm, would you run the CI on this and merge? |
|
@swift-ci test |
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jul 4, 2023
…en test, and disable CxxToSwiftToCxx bridging test that now fails on Android Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jul 16, 2023
…x bridging test Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jul 25, 2023
…x bridging test Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again, and remove the lld_lto feature in the tests, which is now unused.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Aug 2, 2023
…x bridging test Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again, and remove the lld_lto feature in the tests, which is now unused.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Aug 3, 2023
…x bridging test Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again, and remove the lld_lto feature in the tests, which is now unused.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Aug 12, 2023
…x bridging test Also, make the analogous change to swiftlang/swift-driver#1372, which gets the sanitizer tests working on Android again, and remove the lld_lto feature in the tests, which is now unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream change, llvm/llvm-project@a68ccba, broke looking for ASan on Android, so fix it up.
I didn't bother with a test here as it won't run without the Android sanitizers being installed, and this gets the sanitizer tests from the compiler validation suite working on Android anyway.