Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Scanning] Add support for Swift Overlay dependencies as a separate dependency details field #1365

Merged
merged 1 commit into from
May 23, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented May 19, 2023

Instead of assuming such dependencies are contained in the 'directDependencies' field of the module info, support querying them from a details of a textual module.

Adds support for dependency scanner changes added in:
swiftlang/swift#66031

@artemcm artemcm force-pushed the BreakOutOverlayDeps branch from f93f00e to e48a59a Compare May 19, 2023 23:44
… separate dependency details field

Instead of assuming such dependencies are contained in the 'directDependencies' field of the module info, support querying them from a details of a textual module.
@artemcm artemcm force-pushed the BreakOutOverlayDeps branch from e48a59a to 5c08f2b Compare May 19, 2023 23:49
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@artemcm
Copy link
Contributor Author

artemcm commented May 23, 2023

@swift-ci test

@artemcm artemcm merged commit 935daac into swiftlang:main May 23, 2023
@artemcm artemcm deleted the BreakOutOverlayDeps branch May 23, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants