Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify encoding when running a ninja invocation #1358

Merged
merged 1 commit into from
May 9, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 9, 2023

This makes the error messages show up properly in the logs instead of as a binary string.

This makes the error messages show up properly in the logs instead of as a binary string.
@ahoppen ahoppen requested a review from artemcm May 9, 2023 15:26
@ahoppen
Copy link
Member Author

ahoppen commented May 9, 2023

@swift-ci Please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@ahoppen ahoppen merged commit 9cff36e into swiftlang:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants