only use the last file component when deciding decoding strategy #665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://112664398
Summary
Swift CI has started failing on Swift-DocC's tests, because its workspace folder includes an
@
sign. This confuses the SymbolGraphLoader into thinking that there are no base-module symbol graphs, and thus refusing to use theconcurrentlyAllFiles
decoding strategy. This PR updates that logic to only inspect the last path component instead of the full file path, allowing these@
sign directories to successfully detect base-module and extension symbol graphs.Dependencies
None
Testing
Steps:
@
.docc convert
in a debugger and ensure thatSymbolGraphLoader
correctly uses theconcurrentlyAllFiles
decoding strategy to load symbol graph files in parallel.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/test
script and it succeeded