Tests: adjust synchronization tests for Windows #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Kyle-Ye
reviewed
Jun 7, 2023
There was a problem hiding this comment.
Can we add a helper function to this?
private func XXhelper(_ synced: Synchronized) {
#if os(macOS) || os(iOS)
XCTAssertTrue(os_unfair_lock_trylock(synced.lock))
#elseif os(Windows)
XCTAssertNotEqual(TryAcquireSRWLockExclusive(synced.lock), 0)
#elseif os(Linux)
XCTAssertEqual(pthread_mutex_trylock(synced.lock),0)
#endif
}
Kyle-Ye
approved these changes
Jun 7, 2023
Windows does not support pthreads. Adjust the tests to use the Windows APIs for locking where the primitive being used is the `SRWLOCK`.
Address feedback from @Kyle-Ye in swiftlang#615. This avoids replicating the logic for checking the lock state which is already subtle due to the checking of the return value.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not support pthreads. Adjust the tests to use the Windows APIs for locking where the primitive being used is the
SRWLOCK.