Omit the "doc://" and identifier prefix from V2 link(_:) requests
#1320
+81
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://162694487
Summary
This makes a small simplification to the very recently introduced V2 external resolver communication protocol to omit the known "doc://" and identifier prefix—which is the same for every request—so that the resolver implementation doesn't need to parse it to get to the unique portion of the link request.
Dependencies
None.
Testing
bin/test-data-external-resolverscript to write the requests to some file by addingecho $REPLY >> /path/to/some-fileafter thereadlinebin/test-data-external-resolverscript for theDOCC_LINK_RESOLVER_EXECUTABLEenvironmental variable"com.test.bundle"identifier. For example<doc://com.test.bundle/path/to/something>/path/to/some-fileChecklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded