Initial implementation of HTTPCookieStorage #672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushkarnk
commented
Oct 6, 2016
Foundation/NSHTTPCookieStorage.swift
Outdated
| properties["Domain"] = _domain | ||
| return properties | ||
| } | ||
| } |
There was a problem hiding this comment.
This is work in progress. Other properties need to be added.
pushkarnk
force-pushed
the
cookie-storage
branch
from
0e7e566
to
e78f60e
Compare
|
added implementations to a few more methods, tests pending |
pushkarnk
force-pushed
the
cookie-storage
branch
2 times, most recently
from
f187740
to
783820a
Compare
pushkarnk
force-pushed
the
cookie-storage
branch
from
783820a
to
653e71c
Compare
|
I'm working on updating this one. And also waiting on: #889 |
pushkarnk
force-pushed
the
cookie-storage
branch
2 times, most recently
from
3a7234b
to
8c9b7a7
Compare
|
Rebased and updated. This is dependent on the merger of #889 |
naithar
reviewed
Mar 13, 2017
Foundation/NSHTTPCookieStorage.swift
Outdated
|
|
||
| private func createCookie(_ properties: [String: Any]) -> HTTPCookie? { | ||
| var cookieProperties: [HTTPCookiePropertyKey: Any] = [:] | ||
| for key in properties.keys { |
There was a problem hiding this comment.
Wouldn't the use of for (key, value) in properties be more appropriate here as dictionary value is used anyway?
There was a problem hiding this comment.
Thanks @naithar I've updated the patch.
pushkarnk
force-pushed
the
cookie-storage
branch
7 times, most recently
from
c7c82cd
to
abce6a3
Compare
pushkarnk
force-pushed
the
cookie-storage
branch
from
abce6a3
to
1e99d3f
Compare
|
The commit for this PR has now been picked up by #889. |
|
#889 is merged. I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created this pull request for review and comments. There are two important considerations here, around cookie persistence:
TODOs:
sharedCookieStorage(forGroupContainerIdentifier:)ImplementingsortedCookies(using sortOrder: [NSSortDescriptor])NSSortDescriptor is not implemented (is it supported on Linux?)