Move the entire buffer, not half the bytes #5350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
We were only moving half the buffer, as Unichar is 2 bytes.
jmschonfeld
reviewed
Jan 7, 2026
| } | ||
| } | ||
|
|
||
| func test_SurrogatePairsChecking() { |
Contributor
There was a problem hiding this comment.
Can you elaborate on how this unit test tests the code change that you made? If I run the unit test on macOS today, it passes as-is successfully, and if I run it on Linux it crashes due to what looks like a different bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only moving half the buffer, as Unichar is 2 bytes.
Bug also affects macOS CoreFoundation.