Check if length is greater than the buffer size, not if it is greater than count.#5333
Open
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Open
Check if length is greater than the buffer size, not if it is greater than count.#5333SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
SiliconA-Z wants to merge 1 commit intoswiftlang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ICU function ulistfmt_format returns the required buffer length.
If the required length is greater than the buffer we provided (RESULT_BUFFER_SIZE, which is 768), then truncation occurred (or would occur).
Therefore, the check must be length > RESULT_BUFFER_SIZE.