Off-by-one error in precondition#5311
Merged
jmschonfeld merged 2 commits intoswiftlang:mainfrom Jan 13, 2026
Merged
Conversation
Contributor
Author
|
@parkera Thoughts? |
SiliconA-Z
force-pushed
the
import
branch
2 times, most recently
from
b7d2fd4 to
f0d282f
Compare
jmschonfeld
reviewed
Jan 10, 2026
Contributor
jmschonfeld
left a comment
jmschonfeld
left a comment
There was a problem hiding this comment.
Code change itself looks fine to me, but a few minor comments on the unit test
for index <= position, if bytes.count == 0 and index == position, then we don't want this condition to be true at all.
jmschonfeld
reviewed
Jan 12, 2026
Co-authored-by: Jeremy Schonfeld <jeremyschonfeld@gmail.com>
Contributor
|
@swift-ci please test |
Contributor
|
@swift-ci please test Windows platform |
jmschonfeld
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for index <= position, if bytes.count == 0 and index == position, then we don't want this condition to be true at all.