Skip to content

Fix UB in CFBigNumber #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix UB in CFBigNumber #5308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Sources/CoreFoundation/CFBigNumber.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ void _CFBigNumInitWithInt8(_CFBigNum *r, int8_t inNum) {
uint8_t unsignInNum = inNum;
if (inNum < 0) {
r->sign = -1;
unsignInNum = -1 * inNum;
unsignInNum = -1 * unsignInNum;
}
r->digits[0] = unsignInNum;
}
Expand All @@ -77,7 +77,7 @@ void _CFBigNumInitWithInt16(_CFBigNum *r, int16_t inNum) {
uint16_t unsignInNum = inNum;
if (inNum < 0) {
r->sign = -1;
unsignInNum = -1 * inNum;
unsignInNum = -1 * unsignInNum;
}
r->digits[0] = unsignInNum;
}
Expand All @@ -87,7 +87,7 @@ void _CFBigNumInitWithInt32(_CFBigNum *r, int32_t inNum) {
uint32_t unsignInNum = inNum;
if (inNum < 0) {
r->sign = -1;
unsignInNum = -1 * inNum;
unsignInNum = -1 * unsignInNum;
}
uint32_t dig0 = GET_SECOND_DIGIT(unsignInNum);
r->digits[0] = GET_REMAINDER_SECOND_DIGIT(unsignInNum, dig0);
Expand All @@ -99,7 +99,7 @@ void _CFBigNumInitWithInt64(_CFBigNum *r, int64_t inNum) {
uint64_t unsignInNum = inNum;
if (inNum < 0) {
r->sign = -1;
unsignInNum = -1 * inNum;
unsignInNum = -1 * unsignInNum;
}
uint32_t dig2 = GET_THIRD_DIGIT(unsignInNum);
unsignInNum = GET_REMAINDER_THIRD_DIGIT(unsignInNum, (uint64_t)dig2);
Expand All @@ -115,7 +115,7 @@ void _CFBigNumInitWithInt128(_CFBigNum *r, __int128_t inNum) {
__uint128_t unsignInNum = inNum;
if (inNum < 0) {
r->sign = -1;
unsignInNum = -1 * inNum;
unsignInNum = -1 * unsignInNum;
}
uint32_t dig4 = GET_FIFTH_DIGIT(unsignInNum);
unsignInNum = GET_REMAINDER_FIFTH_DIGIT(unsignInNum, (__uint128_t)dig4);
Expand Down