Skip to content

__CFBinaryPlistGetOffsetForValueFromDictionary3 returns null instead of false #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parkera merged 1 commit into from
Dec 11, 2025
Merged

__CFBinaryPlistGetOffsetForValueFromDictionary3 returns null instead of false #5307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/CoreFoundation/CFBinaryPList.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,7 @@ bool __CFBinaryPlistGetOffsetForValueFromDictionary3(const uint8_t *databytes, u
const uint8_t *ptr = NULL;
uint8_t marker = 0;
const uint8_t *extent = NULL;
if (!__CFBinaryPList_beginDictionaryParse(databytes, datalen, startOffset, trailer, &cnt, &ptr, &marker, &extent)) FAIL_NULL;
if (!__CFBinaryPList_beginDictionaryParse(databytes, datalen, startOffset, trailer, &cnt, &ptr, &marker, &extent)) FAIL_FALSE;

// For short keys (15 bytes or less) in ASCII form, we can do a quick comparison check
// We get the pointer or copy the buffer here, outside of the loop
Expand Down