Skip to content

Use popcount instead of manually counting bits #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LumioseSil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use popcount instead of manually counting bits #4838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Sources/CoreFoundation/CFURL.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2375,13 +2375,7 @@ CFURLRef _CFURLCopyFileURL(CFURLRef url)
// get just the component flag bits
UInt32 flags = url->_flags & ALL_COMPONENTS_MASK;
// get the rangeCount -- the number of component flag bits set
CFIndex rangeCount = 0;
while ( flags != 0 ) {
if ( flags & 1 ) {
++rangeCount;
}
flags >>= 1;
}
CFIndex rangeCount = __builtin_popcount(flags);
Comment thread
LumioseSil marked this conversation as resolved.
result = _CFURLAlloc(allocator, rangeCount);
if ( result ) {
// copy the URL fields from _flags to _ranges
Expand Down