Make Foundation compile in Xcode again #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@phausler This allowed foundation to compile in Xcode with latest toolchain |
Contributor
|
It seems like we're not too far away from being Swift 4 compliant, so maybe hold off on this? |
Contributor
Author
|
It was supposed to just be a quick fix as I noticed CI tests were failing on macOS for an xctest PR of mine. #1006 is also needed to get the build working under Xcode. Just thought the swift4 fixes might not go in that quickly with WWDC coming up - and there are a couple more fixes needed on top of the other swift4 PRs as well |
- The code is still using version 3 syntax so pass the -swift-version 3 flag
spevans
force-pushed
the
pr_xcode_swift_version_3
branch
from
3ee0ae5 to
e34ae28
Compare
Contributor
|
@swift-ci test and merge |
Contributor
|
Actually let's just merge this since it's Mac only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-swift-version 3 flag