Merge main into release/6.1
#1892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…targets via a symlink Consider the following scenario: A project has target A containing A.swift an target B containing B.swift. B.swift is a symlink to A.swift. When A.swift is modified, both the dependencies of A and B need to be marked as having an out-of-date preparation status, not just A.
Fix background indexing behavior if a source file is included in two targets via a symlink
VS Code spells file paths with a lowercase drive letter, while the rest of Windows APIs use an uppercase drive letter. Normalize the drive letter spelling to be uppercase. Fixes swiftlang#1855 rdar://141001203
`SourceFilesAndDirectoriesKey` contained all source files in the project and computing its hash value was pretty expensive. The key didn’t really provide any value here because the only way it changes is if the build targets change and if that’s the case, we already clear `cachedSourceFilesAndDirectories`, so we can just avoid the hash value computation.
Improve performance of `sourceFilesAndDirectories`
For reasons that are completely oblivious to me, `DispatchIO.write`, which is used to write LSP responses to stdout fails with error code 5 on Windows unless we call `AbsolutePath(validating:)` on some URL first.
Normalize Windows drive letter to be uppercase
Fix an error that causes SourceKit-LSP to exit immediately on Windows
…s a diagnostic on the source file The missing diagnostics might be due to an error that the user can fix. Report it to them. Fixes swiftlang#1812 rdar://139514623
Fixes swiftlang#1856 rdar://141004197
…gnostics When a sourcekitd diagnostics request fails, show the request error as a diagnostic on the source file
…version Check that we get correct package version even if package manifest is invalid
…mpdb Interpret the `-index-store-path` relative to the command’s directory
bnbarham
approved these changes
Dec 17, 2024
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the following PRs into
release/6.1:sourceFilesAndDirectories#1865-index-store-pathrelative to the command’s directory #1888Do not merge the following PRs into
release/6.1because I want to qualify them onmainfor a little longer: