Merge a111b474 into release/6.0
#1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilding SourceKit-LSP
…yntaxFromSourceKitLSPBuild` I don’t remember the exact failure scenario but there were issues where the modules could be found but linking against the swift-syntax libraries from the sourcekit-lsp build failed. If this happens, skip any macro tests.
…rectory Finder seems to generally struggle opening a temporary directory with many subfolders and eg. hang when zipping the diagnose bundle. Place the diagnose folders in a dedicated subfolder to avoid this.
It turns out that this message was more noise than help. For example, it would often show up when adding a new file to a SwiftPM project: The file gets added before we reload the package and thus we don’t have build settings for the new file for a short while. Since we can’t dismiss the notification we sent to the client, the notification will stick around. Let’s just remove the message.
…r bundle The realpath will be more useful than eg. `/Library/Developer/Toolchains/swift-latest.xctoolchain`.
Include signpost events in OS Logs gathered using `sourcekit-lsp diagnose`
Save sourcekit-lsp diagnose bundles in subdirectories of temporary directory
Try linking again SwiftSyntax in `SkipUnless.canBuildMacroUsingSwiftSyntaxFromSourceKitLSPBuild`
…g-compiler-args Remove warning message about missing compiler arguments
…set it using `sh` In particular, this affects Amazon Linux 2, which has a glibc that doesn’t support `posix_spawn_file_actions_addchdir_np`. rdar://128016626
…hain-txt Resolve symlinks in toolchain path when creating sourcekitd reproducer bundle
Currently the name of the command is `source-kit-lsp` in `sourcekit-lsp --help` output: ``` ❯ sourcekit-lsp --help OVERVIEW: Language Server Protocol implementation for Swift and C-based languages USAGE: source-kit-lsp <options> <subcommand> ```
…dexing-instructions Simplify instructions to enable background indexing to not require building SourceKit-LSP
Fix a few Swift concurrency warnings
Fix incorrect command name in `sourcekit-lsp --help` output
…mazonlinux When setting a working directory on process launch is not supported, set it using `sh`
…e-main-2024-06-22
Member
Author
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the following PRs into
release/6.0sourcekit-lsp diagnose#1486SkipUnless.canBuildMacroUsingSwiftSyntaxFromSourceKitLSPBuild#1484sourcekit-lsp --helpoutput #1497sh#1485