Only report log collection progress in sourcekit-lsp diagnose if we’ve made meaningful progress
#1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
hamishknight
approved these changes
Jun 5, 2024
Comment on lines
226
to
228
| if progress - lastReportedProgress > 0.01 { | ||
| // Only call `reportProgress` when we've made at least 1% of progress (which will get scaled down further | ||
| // based on the other components). This avoids us spamming the console with non-meaningful progress updates. |
Contributor
There was a problem hiding this comment.
IMO it seems like this is something that should be handled by reportProgress, but I don't feel strongly about it
Member
Author
There was a problem hiding this comment.
Yes, that’s probably the better design. Updated.
…’ve made meaningful progress Especially when we didn’t have a redrawing progress indicator, we would spam the output with out making progress that was visible to the user because the overall progress just shows a percentage without any decimal digits. To fix this, only report progress when we’ve made at least 1% of progress in log collection.
ahoppen
force-pushed
the
dont-spam-log-progress
branch
from
336f3d3 to
6425a8e
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially when we didn’t have a redrawing progress indicator, we would spam the output with out making progress that was visible to the user because the overall progress just shows a percentage without any decimal digits. To fix this, only report progress when we’ve made at least 1% of progress in log collection.