Don’t start executing a task when cancelToBeRescheduled is called before execute
#1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
bnbarham
approved these changes
May 31, 2024
hamishknight
approved these changes
May 31, 2024
|
@swift-ci please test |
Member
Author
|
@swift-ci Please test macOS |
…ead of an atomic It’s only modified from method isolated to `QueuedTask`, so there’s no need for it to be an `AtomicBool`.
…efore `execute` `QueuedTask.execute` is called from a detached task in `TaskScheduler.poke` but we insert it into the `currentlyExecutingTasks` queue beforehand. This left a short windows in which we could cancel the task to reschedule it before it actually started executing. Change `QueuedTask` to just return immediately from `execute` if it has been cancelled to be rescheduled beforehand.
ahoppen
force-pushed
the
cancel-task-before-execution-started
branch
from
8112854 to
cc1280f
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueuedTask.executeis called from a detached task inTaskScheduler.pokebut we insert it into thecurrentlyExecutingTasksqueue beforehand. This left a short windows in which we could cancel the task to reschedule it before it actually started executing.Change
QueuedTaskto just return immediately fromexecuteif it has been cancelled to be rescheduled beforehand.