Skip to content

On macOS, reveal diagnostic bundle in Finder after it has been created #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahoppen merged 1 commit into from
May 24, 2024
Merged

On macOS, reveal diagnostic bundle in Finder after it has been created #1346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Sources/Diagnose/DiagnoseCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,15 @@ public struct DiagnoseCommand: AsyncParsableCommand {
"""
)

#if os(macOS)
// Reveal the bundle in Finder on macOS
do {
let process = try Process.launch(arguments: ["open", "-R", bundlePath.path], workingDirectory: nil)
try await process.waitUntilExitSendingSigIntOnTaskCancellation()
} catch {
// If revealing the bundle in Finder should fail, we don't care. We still printed the bundle path to stdout.
}
#endif
}

@MainActor
Expand Down