Add some logging to TaskScheduler again
#1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
approved these changes
May 22, 2024
Member
Author
|
@swift-ci Please test |
ahoppen
force-pushed
the
task-scheduler-logging
branch
from
adcccf9 to
bdc130b
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
bnbarham
approved these changes
May 23, 2024
ahoppen
force-pushed
the
task-scheduler-logging
branch
from
bdc130b to
d568264
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
Turns out that some of logging from task scheduler would have been useful to debug a recent test failure. This adds some logging into `TaskScheduler` again and, most importantly, adds log messages to `ClosureTaskDescription` in `TaskSchedulerTests`.
…heduler` We need this function anyway to escalate process priorities when we set `nice`ness values for them. It also simplifies the task scheduler and I’m hoping that it fixes a non-deterministic failure that causes task priority elevation to not work properly.
ahoppen
force-pushed
the
task-scheduler-logging
branch
from
d568264 to
ef9cd63
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
hamishknight
approved these changes
May 23, 2024
| public static func platformSupportsTaskPriorityElevation() throws { | ||
| #if os(macOS) | ||
| if #available(macOS 14.0, *) { | ||
| // |
Contributor
There was a problem hiding this comment.
Was there meant to be a comment here?
Member
Author
There was a problem hiding this comment.
It also meant to be negated 😉
Member
Author
There was a problem hiding this comment.
Added
// Priority elevation was implemented by https://github.com/apple/swift/pull/63019, which is available in the
// Swift 5.9 runtime included in macOS 14.0+… doesn’t support task priority elevation
ahoppen
force-pushed
the
task-scheduler-logging
branch
from
ef9cd63 to
cb24ce9
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Linux |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Linux |
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that some of logging from task scheduler would have been useful to debug a recent test failure. This adds some logging into
TaskScheduleragain and, most importantly, adds log messages toClosureTaskDescriptioninTaskSchedulerTests.rdar://127474171