Fix non-deterministic test failure in BackgroundIndexingTests.testPrepareTarget
#1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epareTarget` We could get `DocumentDiagnosticsRequest` triggered from file changes or old preparation operations during the initial build without actually having re-prepared the target after the file change. Make the test wait until it receives expected diagnostics after the file change.
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
bnbarham
approved these changes
May 17, 2024
hamishknight
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could get
DocumentDiagnosticsRequesttriggered from file changes or old preparation operations during the initial build without actually having re-prepared the target after the file change. Make the test wait until it receives expected diagnostics after the file change.