-
Notifications
You must be signed in to change notification settings - Fork 325
Support background preparation of targets #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci Please test |
64865b8 to
7d8e10c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
| try self.workspace.resolve( | ||
| root: PackageGraphRootInput(packages: [AbsolutePath(projectRoot)]), | ||
| observabilityScope: observabilitySystem.topScope | ||
| ) | ||
| try await self.reloadPackage() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like reloadPackage calls loadPackageGraph, which calls into _resolve, is our call to resolve necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a subtle difference here that we don’t set forceResolvedVersions: true here. This ensures that we generate a Package.resolved if none exists. I think we need to do some more design work here about when we should do it. I’ll file an issue for it and do it in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I had to set forceResolvedVersions: false during an index build anyway. 5e83d7d
…ld directory When `SwiftPMBuildSystem` operates on a ` .index-build` directory, it owns the checkouts and is thus also allowed to resolve the package versions. This is necessary
7d8e10c to
740262c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
No description provided.