Refactor SemanticTokenTypes, SemanticTokenModifiers #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I appreciate review/comment on that |
ahoppen
reviewed
Jan 8, 2024
Comment on lines
50
to
51
| public typealias Kind = SemanticTokenTypes | ||
| public typealias Modifiers = SemanticTokenModifiers |
Member
There was a problem hiding this comment.
Do we need these typealias declarations or can we just use SemanticTokenTypes and SemanticTokenModifiers?
ahoppen
approved these changes
Jan 8, 2024
Member
|
@swift-ci Please test |
Member
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
SyntaxHighlightingToken.KindandSyntaxHighlightingToken.ModifiersintoSemanticTokenTypesandSemanticTokenModifiers. This change moves types fromSourceKitLSPtoLanguageServerProtocolwhere it belongs.SemanticTokenTypesis extended with additional types inSyntaxHighlightingToken.swiftthat is then used by the server.Resolves #1010