Add libclang API to store and query CAS objects #8937
Conversation
|
@swift-ci Please test LLVM |
| /** | ||
| * Stores an object in the CAS. | ||
| * | ||
| * \param Refs The refs of the object to be stored. |
There was a problem hiding this comment.
I think the Refs are CASID here? That is probably a bit confusing since ObjectRef is something slightly different.
I am ok with using CASID on API level as it is easier to print but it is not efficient to use this API to write large amount of connected CAS objects (while ObjectRef is very efficient).
|
I chatted a bit with @owenv, I'm not sure we should be exposing generic CAS APIs from libclang. I suggested to Owen to use the llvm-c CAS API instead for experimentation purposes. |
|
Yeah, using llcas C APIs are probably better if that is the direction we are going. I have a prototype of wrapping some simple API in swift-driver long time ago: swiftlang/swift-driver#1415 |
|
sounds good, closing this for now |
Allow libclang clients to directly access data and refs of CAS objects, and store new CAS objects