Keep start and stop symbols linked through clang (Linux)#8214
Keep start and stop symbols linked through clang (Linux)#8214etcwilde wants to merge 1 commit intoswiftlang:stable/20230725from
Conversation
Changes in https://reviews.llvm.org/D96914 taught LLD to remove `__start_##name` and `__stop_##name` symbol names. The Swift runtime uses these specially named symbols to unpack the runtime type metadata on Linux and WebAssembly systems, resulting in broken binaries when linked with `lld`. This change tells the Swift-paired Clang to force the `-z nostart-stop-gc` flag when compiling for Linux-y systems, including Musl, WASM, and Android. Swift and the clang-linker have to work with other existing toolchains, so we can't simply flip the cmake option in the LLVM build system to keep these symbols and get a working binary.
|
@swift-ci please test |
|
I have checked this manually with |
|
I think that you can add a test in |
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This does deserve a test as we are diverging from upstream and we don't want to lose the difference accidentally.
| return std::string(UseLinker); | ||
| } else { | ||
| llvm::SmallString<8> LinkerName; | ||
| llvm::SmallString<8> LinkerName = {}; |
There was a problem hiding this comment.
This seems unnecessary? Would be nice to stay as close to upstream as possible.
| bool useLLD = false; | ||
| const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath(&useLLD)); | ||
| if (useLLD) { |
There was a problem hiding this comment.
Why not if (Args.hasArg(options::OPT_fuse_ld_EQ) && Args.getLastArgValue(options::OPT_fuse_ld_EQ).ends_with_insensitive("lld"))?
There was a problem hiding this comment.
Yeah, mainly to support when someone isn't passing --fuse-ld=lld. It should still catch it if clang was configured to use lld by default. We're already calling GetLinkerPath, which is also conveniently supposed to detect when the linker is lld either through clang being configured to use lld by default, --fuse-ld=lld, or --ld-path=<filepath>/ld.lld.
|
I prefer swiftlang/swift#72061 to resolve this issue. |
2 participants
Changes in https://reviews.llvm.org/D96914 taught LLD to remove
__start_##nameand__stop_##namesymbol names. The Swift runtime uses these specially named symbols to unpack the runtime type metadata on Linux and WebAssembly systems, resulting in broken binaries when linked withlld. This change tells the Swift-paired Clang to force the-z nostart-stop-gcflag when compiling for Linux-y systems, including Musl, WASM, and Android. Swift and the clang-linker have to work with other existing toolchains, so we can't simply flip the CMake option in the LLVM build system to keep these symbols and get a working binary.