Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang] Report the on-disk paths for inputs to module compiles #6005

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[clang] Report the on-disk paths for inputs to module compiles #6005

merged 1 commit into from
Jan 17, 2023

Conversation

jansvoboda11
Copy link

No description provided.

@jansvoboda11
[clang] Report the on-disk paths for inputs to module compiles
2216ee8 
Since D135636, PCM files contain the "as requested" path of input files. The machinery for generating dependency files reports those paths as they appeared in the PCM file, which may confuse consumers that are not aware of VFS overlays that might've been in place at compile-time.

This patch makes sure the "use-external-name" setting is being respected when generating dependency files in modular builds by piping the paths serialized in PCMs through `FileEntryRef::getName()` before putting them into dependency files.

rdar://103459532

Reviewed By: benlangmuir

Differential Revision: https://reviews.llvm.org/D141644

(cherry picked from commit 347028a)
@jansvoboda11
Copy link
Author

@swift-ci please test

@jansvoboda11 jansvoboda11 merged commit 727d88c into stable/20221013 Jan 17, 2023
@jansvoboda11 jansvoboda11 deleted the jan_svoboda/stable-20221013-vfs-dep-cherry-pick branch January 17, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jansvoboda11