Skip to content

🍒 [lldb][PECOFF] Recognise truncated .lldb{summaries,formatters} section names #13070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charles-zablit wants to merge 1 commit into
base: swift/release/6.4.x
Choose a base branch
from
Open

🍒 [lldb][PECOFF] Recognise truncated .lldb{summaries,formatters} section names #13070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,14 +996,17 @@ SectionType ObjectFilePECOFF::GetSectionType(llvm::StringRef sect_name,

SectionType section_type =
llvm::StringSwitch<SectionType>(sect_name)
// PE/COFF image-file section names are limited to 8 characters,
// so the linker truncates the longer source names. Match both.
.Cases({".eh_frame", ".eh_fram"}, eSectionTypeEHFrame)
.Cases({".gosymtab", ".gosymta"}, eSectionTypeGoSymtab)
.Cases({".lldbsummaries", ".lldbsum"},
lldb::eSectionTypeLLDBTypeSummaries)
.Cases({".lldbformatters", ".lldbfor"},
lldb::eSectionTypeLLDBFormatters)
.Case(".debug", eSectionTypeDebug)
.Case(".stabstr", eSectionTypeDataCString)
.Case(".reloc", eSectionTypeOther)
// .eh_frame can be truncated to 8 chars.
.Cases(".eh_frame", ".eh_fram", eSectionTypeEHFrame)
.Case(".gosymtab", eSectionTypeGoSymtab)
.Case(".lldbsummaries", lldb::eSectionTypeLLDBTypeSummaries)
.Case(".lldbformatters", lldb::eSectionTypeLLDBFormatters)
.Case("swiftast", eSectionTypeSwiftModules)
.Default(eSectionTypeInvalid);
if (section_type != eSectionTypeInvalid)
Expand Down
1 change: 0 additions & 1 deletion lldb/test/API/functionalities/data-formatter/bytecode-summary/TestBytecodeSummary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@


class TestCase(TestBase):
@skipUnlessDarwin
def test(self):
self.build()
if self.TraceOn():
Expand Down
2 changes: 0 additions & 2 deletions lldb/test/API/functionalities/data-formatter/bytecode-synthetic/TestBytecodeSynthetic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@


class TestCase(TestBase):
@skipUnlessDarwin
def test_synthetic(self):
self.build()
if self.TraceOn():
Expand All @@ -22,7 +21,6 @@ def test_synthetic(self):

self.expect("v acc", matching=False, substrs=["password"])

@skipUnlessDarwin
def test_update_reuse(self):
self.build()

Expand Down