Skip to content

[Test-only] Cherry-picks for sanitizer remote testing#12111

Merged
ndrewh merged 7 commits intoswiftlang:stable/21.xfrom
ndrewh:darwin-remote-testing
Jan 18, 2026
Merged

[Test-only] Cherry-picks for sanitizer remote testing#12111
ndrewh merged 7 commits intoswiftlang:stable/21.xfrom
ndrewh:darwin-remote-testing

Conversation

@ndrewh
Copy link

@ndrewh ndrewh commented Jan 12, 2026

[compiler-rt] [Darwin] Add darwin-remote feature for remote darwin test targets (llvm#174905)
[ASan] Re-enable duplicate_os_log_reports test and include cstdlib for malloc (llvm#153195)
[compiler-rt] Support default-True lit config options (follow up to llvm#174522) (llvm#174642)
[sanitizer_common][test-only] Mark popen xfail on iossim (llvm#171814)
[sanitizer_common][test-only] Remove xfail for darwin ubsan on dedup_token_length_test (llvm#171812)
[NFCI] [Darwin] Add APPLE_TARGET_IS_HOST lit option to compiler-rt (llvm#174522)
[compiler-rt][sanitizer_common] Make sanitizer_common tests work for other Apple Platforms (llvm#150994)

DanBlackwell and others added 7 commits January 12, 2026 15:35
…other Apple Platforms (llvm#150994)

This commit addresses a longstanding TODO comment, by doing the
following:
* Modifies the CMakeLists to add the new test configs
* Modifies the relevant lit file to add the required envs
* Fixes the FileCheck match in
`Darwin/symbolizer-function-offset-atos.cpp`
* XFAILs any appropriate tests

rdar://107758331
(cherry picked from commit 365ae7a)
…lvm#174522)

Darwin supports running tests on targets other than the host machine
e.g. simulators. In such configurations, tests are run via a wrapper
script (e.g. iossim_run.py).

This refactors the lit test config to use a dedicated option to
distinguish test suites that run on the host from those that run in any
other configuration. This will allow the test suites to distinguish a
local osx configuration from a "remote" one.

rdar://167591463
(cherry picked from commit 305c413)
…token_length_test (llvm#171812)

This test is currently XPASSing on the iossim CI.

rdar://166219043
(cherry picked from commit f548902)
…lvm#174522) (llvm#174642)

The option added in llvm#174522 breaks simulator tests, since `set_default`
overrides `False` values with the default.

Since these options are either string or boolean, this patches
set_default to override only un-set or empty string values (empty string
is not truth-y and therefore would be overwritten by defaults currently,
so this is NFCI)

(cherry picked from commit 0aea22f)
…st targets (llvm#174905)

Some tests are already supported on "remote" devices and simulators.
However, there is currently no way to distinguish a remote macOS host
from a local one.

This adds the darwin-remote feature which is common to all test targets
which use a wrapper script (e.g. iossim_run.py).

rdar://167735355

---------

Co-authored-by: Dan Blackwell <danblackwell95@gmail.com>
(cherry picked from commit 65945ec)
@ndrewh ndrewh requested a review from DanBlackwell January 12, 2026 23:47
@ndrewh ndrewh requested a review from a team as a code owner January 12, 2026 23:47
@ndrewh
Copy link
Author

ndrewh commented Jan 12, 2026

@swift-ci please test

@ndrewh
Copy link
Author

ndrewh commented Jan 13, 2026

@swift-ci please test linux

@DanBlackwell
Copy link

@swift-ci please test llvm

@ndrewh
Copy link
Author

ndrewh commented Jan 13, 2026

@swift-ci please test llvm

@ndrewh
Copy link
Author

ndrewh commented Jan 18, 2026

llvm test fails look unrelated considering this is a runtime-only change. I've run check-sanitizer-iossim-arm64 locally and it seems fine

@ndrewh ndrewh merged commit 36faa0e into swiftlang:stable/21.x Jan 18, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants