[AArch64] Make StackTagging pass use alloca getAllocationSize rather than lifetime size #11970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lifetime size This was causing zero sized setTags to be emitted when compiling with Swift with memtag-stack sanitization; this caused an assert in the backend 'N->getOpcode() != ISD::EntryToken && "EntryToken in CSEMap!"'. This patch does as the title says and replaces the use of the lifetime size argument with AllocaInst.getAllocationSize. rdar://164400893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing zero sized setTags to be emitted when compiling Swift class initializers with memtag-stack sanitization; this caused an assert in the backend 'N->getOpcode() != ISD::EntryToken && "EntryToken in CSEMap!"'.
This patch does as the title says and replaces the use of the lifetime size argument with AllocaInst.getAllocationSize.
rdar://164400893