Fix bug in cas-friendly-debug-info option. #11641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug with emitting a DW_LNS_set_file at the beginning of a new function's contribution to a line table, when the -cas-friendly-debug-info option is passed. We were setting the current FileNum to 0, however, if the LineEntry to be emitted also has the FileNum be 0, we don't emit a DW_LNS_set_file at all, it is only emitted if the current FileNum and the LineEntry to be emitted have different FileNums. To fix this, in cas-friendly-debug-info, we always set the current FileNum to be -1. rdar://161930616 (cherry picked from commit 823563a)
|
@swift-ci please test |
adrian-prantl
approved these changes
Oct 16, 2025
cachemeifyoucan
approved these changes
Oct 16, 2025
|
@swift-ci please test windows |
I had the same reaction but it turns out the comment explaining it was already there, just the default wasn't chosen correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with emitting a DW_LNS_set_file at the beginning of a new function's contribution to a line table, when the
-cas-friendly-debug-info option is passed. We were setting the current FileNum to 0, however, if the LineEntry to be emitted also has the FileNum be 0, we don't emit a DW_LNS_set_file at all, it is only emitted if the current FileNum and the LineEntry to be emitted have different FileNums.
To fix this, in cas-friendly-debug-info, we always set the current FileNum to be -1.
rdar://162777991
(cherry picked from commit 823563a)