-
Notifications
You must be signed in to change notification settings - Fork 350
[CAS] OnDisk update/cleanup. NFCI. #11609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAS] OnDisk update/cleanup. NFCI. #11609
Conversation
|
@swift-ci please test llvm |
7950626 to
8ff887a
Compare
|
@swift-ci please test llvm |
|
This is a clean up for upstream review. NFC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message/PR description should probably mention that we are changing from a per-file format version to a single version across the files (currently actions has a different version from the others).
Mostly LGTM. A few nits and suggestions.
2810a96 to
d5c7e20
Compare
|
@swift-ci please test llvm |
4a756e3 to
87e64d0
Compare
Cleanup for code upstreaming. Noticeable changes: * Hide some forward declared typesA. * Rename all the database files and use a unified version across index and dabasefile. This allows reset the version while not introduce downstream incompatibility. * Change unit-test to properly set a smaller file size and just not building OnDiskCAS test.
87e64d0 to
9dada99
Compare
|
@swift-ci please test llvm |
Cleanup for code upstreaming. Noticeable changes:
* Hide some forward declared typesA.
* Rename all the database files and use a unified version across index
and dabasefile. This allows reset the version while not introduce
downstream incompatibility.
* Change unit-test to properly set a smaller file size and just not
building OnDiskCAS test