Auto upgrade bitcode to new vararg representation for coro.id.retcon.once intrinsic #10554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…once intrinsic The signature of coro.id.retcon.once intrinsic was modified in #10015 with an extra vararg. This commit adds an auto upgrader to LLVM in order to be compatible with compilers generating old bitcode (intrinsic without the vararg). rdar://147426562 (cherry picked from commit 969660b) (cherry picked from commit 2eaa148) (cherry picked from commit 889ce26) (cherry picked from commit 031baa1) (cherry picked from commit 98dd062)
Author
|
@swift-ci test |
Author
|
@swift-ci test llvm |
cachemeifyoucan
approved these changes
Apr 25, 2025
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
LGTM. I think you need to nominate for release/6.2 branch as well. Thanks!
Author
|
@swift-ci please test |
Author
|
@swift-ci test llvm |
Author
|
The failures are unrelated to this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of coro.id.retcon.once intrinsic was modified in #10015 with an extra vararg. This commit adds an auto upgrader to LLVM in order to be compatible with compilers generating old bitcode (intrinsic without the vararg).
rdar://147426562
(cherry picked from commit 969660b)
(cherry picked from commit 2eaa148)
(cherry picked from commit 889ce26)
(cherry picked from commit 031baa1)
(cherry picked from commit 98dd062)