-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamable output refresh is size limited to 4k, won't allow | image=(base64data)
#371
Closed
1 task done
Milestone
Comments
peanball
added a commit
to peanball/SwiftBar
that referenced
this issue
Apr 8, 2023
…ng items Process output is streamed into a buffer. By default this buffer fits 4k characters, which is too short for image data. With this change, if this block does not contain a stream separator, the complete block is appended to the in-progress content stored so far. Fixes swiftbar#371.
peanball
added a commit
to peanball/SwiftBar
that referenced
this issue
Apr 8, 2023
…ng items Process output is streamed into a buffer. By default this buffer fits 4k characters, which is too short for image data. With this change, if this block does not contain a stream separator, the complete block is appended to the in-progress content stored so far. Fixes swiftbar#371.
peanball
added a commit
to peanball/SwiftBar
that referenced
this issue
Apr 8, 2023
…ng items Process output is streamed into a buffer. By default this buffer fits 4k characters, which is too short for image data. With this change, if this block does not contain a stream separator, the complete block is appended to the in-progress content stored so far. Fixes swiftbar#371.
peanball
added a commit
to peanball/SwiftBar
that referenced
this issue
Apr 8, 2023
…ng items Process output is streamed into a buffer. By default this buffer fits 4k characters, which is too short for image data. With this change, if this block does not contain a stream separator, the complete block is appended to the in-progress content stored so far. Fixes swiftbar#371.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The streamable plugin option reads data from the script's output stream and forwards it to the streamable output processing, which checks for
~~~
. The reading is buffered and by system defaults limited to ca. 4k, while the rest of the stream may not be read.To Reproduce
Produce an image output:
This should produce a complete image but the image is broken.
Expected behavior
The image is loaded properly
Screenshots
Environment:
Plugin Example:
Sample plugin to reproduce the issue, link or code.
(not tested. I will test later and in more detail)
Additional Context:
I am currently working on a streaming version of the iTunes / Music status "Now Playing" plugin and wanted to add album art. The script works fine but the album art doesn't load.
If I find time before you, I might open a PR with a fix. I can test changes and have the above now playing script that is an extensive "test suite".I found the edge case that wasn't handled in the stream output processing and propose a simple fix in #372.
The text was updated successfully, but these errors were encountered: