Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in emoji code? #335

Closed
arohl opened this issue Oct 9, 2022 · 4 comments
Closed

Bug in emoji code? #335

arohl opened this issue Oct 9, 2022 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@arohl
Copy link

arohl commented Oct 9, 2022

My plugin that alert me to upcoming cricket games yields

:australia: v :england: 3:03 | symbolize=false
---
Australia vs England starts on Sun Oct 09 at 4:10 PM | color = royalblue

The Australian flag renders correctly but the English one renders as the text :england: not the flag. I note that if I unquote the text in for the flag in this report I get the rendered flag - 🏴󠁧󠁢󠁥󠁮󠁧󠁿 on my Mac and I thought both the GitHub website and SwiftBar use the same rendering engine!

melonamin added a commit that referenced this issue Oct 15, 2022
@melonamin
Copy link
Contributor

Hey @arohl,

For whatever reason I have implemented it this way:

    ":gb:": "🇬🇧",
    ":uk:": "🇬🇧",

So if you replace :england: to :uk: you'll see the flag.

I've added :england: as an option as well, it will be available in the next release

@melonamin melonamin added this to the 1.4.4 milestone Oct 15, 2022
@arohl
Copy link
Author

arohl commented Oct 15, 2022

Hey @arohl,

For whatever reason I have implemented it this way:

    ":gb:": "🇬🇧",
    ":uk:": "🇬🇧",

So if you replace :england: to :uk: you'll see the flag.

I've added :england: as an option as well, it will be available in the next release

That's because the flag you are showing is the UK flag i.e. 🇬🇧 whilst the England flag is only the Red Cross of St George 🏴󠁧󠁢󠁥󠁮󠁧󠁿

Scotland and Ireland also have cricket teams who are playing in the World Cup in Australia that started today!

@melonamin
Copy link
Contributor

Note to self - don't work on GitHub issues before morning coffee 😅

Got it, I've added a proper :england: 🏴󠁧󠁢󠁥󠁮󠁧󠁿 flag, will be available with the 1.4.4 release, which I hope to publish soon.

@melonamin melonamin added the bug Something isn't working label Oct 15, 2022
@arohl
Copy link
Author

arohl commented Oct 15, 2022

😃

@arohl arohl closed this as completed Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants