storeMessageOffset: ignore state error
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Previously, we failed the entire `KafkaConsumer` if storing a message offset through `RDKafkaClient.storeMessageOffset` failed because the partition the offset should be committed to was unassigned (which can happen during rebalance). We should not fail the consumer when committing during rebalance. The worst thing that could happen here is that storing the offset fails and we re-read a message, which is fine since KafkaConsumers with automatic commits are designed for at-least-once processing: https://docs.confluent.io/platform/current/clients/consumer.html#offset-management Modifications: * `RDKafkaClient.storeMessageOffset`: don't throw when receiving error `RD_KAFKA_RESP_ERR__STATE`
FranzBusch
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously, we failed the entire
KafkaConsumerif storinga message offset through
RDKafkaClient.storeMessageOffsetfailed because the partition the offset should be committed to
was unassigned (which can happen during rebalance).
We should not fail the consumer when committing during
rebalance.
The worst thing that could happen here is that storing the offset
fails and we re-read a message, which is fine since KafkaConsumers with
automatic commits are designed for at-least-once processing:
https://docs.confluent.io/platform/current/clients/consumer.html#offset-management
Modifications:
RDKafkaClient.storeMessageOffset: don't throw when receivingerror
RD_KAFKA_RESP_ERR__STATE