KafkaConsumer: change locality of message error
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Aug 24, 2023
|
@felixschlegel Please update |
Motivation: If the `KafkaConsumer` receives an errorneous message, it should not throw in the `func run()` method but rather in the `KafkaConsumer.messages` `ThrowingSequence`. Modifications: * make `KafkaConsumerMessages` `AsyncSequence` wrap a sequence that yields a `Result<>` type -> `KafkaConsumerMessages` unwraps this result type and either yields or throws
auto-merge was automatically disabled
August 24, 2023 13:05
Head branch was pushed to by a user without write access
felixschlegel
force-pushed
the
fs-kafka-consumer-message-error-throw-in-async-sequence
branch
from
de66afd to
9f90a5b
Compare
FranzBusch
approved these changes
Aug 24, 2023
FranzBusch
deleted the
fs-kafka-consumer-message-error-throw-in-async-sequence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If the
KafkaConsumerreceives an errorneous message, it should notthrow in the
func run()method but rather in theKafkaConsumer.messagesThrowingSequence.Modifications:
KafkaConsumerMessagesAsyncSequencewrap a sequence thatyields a
Result<>type ->KafkaConsumerMessagesunwraps thisresult type and either yields or throws