Fix OOM issue when setting concurrentHTTP1ConnectionsPerHostSoftLimit
to Int.max
#763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a user wishes to make the connection pool create as many concurrent connections as possible, a natural way to achieve this would be to set
.max
to theconcurrentHTTP1ConnectionsPerHostSoftLimit
property.The
concurrentHTTP1ConnectionsPerHostSoftLimit
property is of typeInt
. Setting it toInt.max
leads toInt.max
being passed as an argument toArray
s.reserveCapacity(_:)
method, causing an OOM issue.Addresses Github Issue #751
Modifications:
Capped the argument to
self.connections.reserveCapacity(_:)
to 1024 inHTTPConnectionPool.HTTP1Connections
Result:
Users can now set the
concurrentHTTP1ConnectionsPerHostSoftLimit
property to.max
without causing an OOM issue.