Fix leading slash issue in relative URL requests #747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
string
argument of a relativeURL
instance constructed frominit(string:relativeTo)
, requests made with thisURL
instance fail. This is because the underlying HTTP parser fails when there is no leading slash in the URI.Modifications:
URL
instance is obtained from a computed propertyuri
inHTTPHandler.swift
, which in turn calls thepercentEncodedPath
computed property.percentEncodedPath
property usesURLComponents
to extract out the path.resolvingAgainstBaseURL
argument to theURLComponents
constructor was modified fromfalse
totrue
Result:
URL
, theuri
property will always contain a leading slash.