Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase decompression limit ratio of HTTPClient.shared 10 -> 25 #740

Merged
merged 3 commits into from
May 9, 2024

Conversation

MahdiBM
Copy link
Contributor

@MahdiBM MahdiBM commented Apr 16, 2024

This enables the decompressor to decompress files that have been 96% compressed, instead of the previous 90%, when using HTTPClient.shared.

See #739.

I'm also fine with decreasing the ratio to 20, if 25 seems too high.

@MahdiBM
Copy link
Contributor Author

MahdiBM commented Apr 30, 2024

@Lukasa since you were responding on the issue 🙂

@FranzBusch
Copy link
Collaborator

@swift-server-bot test this please

@Lukasa Lukasa added the semver/patch For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label May 9, 2024
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

@Lukasa
Copy link
Collaborator

Lukasa commented May 9, 2024

@swift-server-bot test this please

@Lukasa Lukasa enabled auto-merge (squash) May 9, 2024 12:17
@Lukasa Lukasa merged commit 0ae99db into swift-server:main May 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants