Use the given connection pool idle timeout in the HTTPClient.Configuration inits #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
approved these changes
Dec 20, 2023
gjcairo
force-pushed
the
connection-pool-idle-timeout-propagation
branch
from
6ea7a0b
to
e5f06e3
Compare
gjcairo
added
the
semver/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We provide some initialisers for
HTTPClient.Configurationwhere users can provide idle timeouts for the connection pools used. However, we don't propagate those values down to the connection pool. This caused bugs in adopters' code.Modifications
Propagate the idle timeout down to the connection pool.
Result
The given idle timeout is now actually used.