Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing availability guards in tests #719

Conversation

simonjbeaumont
Copy link
Collaborator

Motivation

Some of the test code was missing availability guards for Apple platforms, resulting in build failures for these platforms, e.g.

error: 'AsyncSequence' is only available in iOS 13.0 or newer

Modifications

Add missing availability guards. I've tried to keep them as scoped as possible.

Result

Tests can now build for run on iOS and other Apple platforms.

@glbrntt
Copy link
Collaborator

glbrntt commented Dec 15, 2023

@swift-server-bot add to allowlist

@glbrntt glbrntt added the semver/none For PRs that when merged do not need a bump in version number. label Dec 15, 2023
@glbrntt glbrntt enabled auto-merge (squash) December 15, 2023 16:00
@simonjbeaumont
Copy link
Collaborator Author

@swift-server-bot test this please

@simonjbeaumont
Copy link
Collaborator Author

@dnadoba looks like @glbrntt's attempt to allowlist me for CI failed; could you try?

@dnadoba
Copy link
Collaborator

dnadoba commented Dec 18, 2023

@swift-server-bot add to allowlist

@simonjbeaumont simonjbeaumont force-pushed the sb/add-missing-availabilty-guards-in-tests branch 2 times, most recently from a83a49f to c96e0c8 Compare December 18, 2023 12:42
@simonjbeaumont simonjbeaumont force-pushed the sb/add-missing-availabilty-guards-in-tests branch from c96e0c8 to 853003f Compare December 18, 2023 12:47
@simonjbeaumont simonjbeaumont enabled auto-merge (squash) December 18, 2023 12:47
@simonjbeaumont simonjbeaumont merged commit a4904fc into swift-server:main Dec 18, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants