Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong/outdated connect timeout documentation #714

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix wrong/outdated connect timeout documentation #714

merged 1 commit into from
Oct 25, 2023

Conversation

MahdiBM
Copy link
Contributor

@MahdiBM MahdiBM commented Oct 25, 2023

The documentation states 30 seconds but other documentations and the implementation all agree on 10 seconds timeout as HTTPClient.Configuration.connect.

dnadoba
dnadoba approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

@Lukasa
Copy link
Collaborator

Lukasa commented Oct 25, 2023

@swift-server-bot test this please

@Lukasa Lukasa added the semver/none For PRs that when merged do not need a bump in version number. label Oct 25, 2023
@Lukasa Lukasa enabled auto-merge (squash) October 25, 2023 15:13
@Lukasa Lukasa merged commit 4824907 into swift-server:main Oct 25, 2023
6 of 8 checks passed
@MahdiBM MahdiBM deleted the patch-1 branch October 25, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadoba dnadoba dnadoba approved these changes

Assignees
No one assigned
Labels
semver/none For PRs that when merged do not need a bump in version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MahdiBM @Lukasa @dnadoba