Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Swift version to 5.7 #712

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

rnro
Copy link
Collaborator

@rnro rnro commented Oct 4, 2023

Motivation:

Now that Swift 5.9 is GM we should update the supported versions and remove 5.6

Modifications:

  • Update Package.swift
  • Remove #if swift(>=5.7) guards
  • Delete the 5.6 docker compose file and make a 5.10 one
  • Update docs

Result:

Remove support for Swift 5.6, add 5.10

Motivation:

Now that Swift 5.9 is GM we should update the supported versions and
remove 5.6

Modifications:

* Update `Package.swift`
* Remove `#if swift(>=5.7)` guards
* Delete the 5.6 docker compose file and make a 5.10 one
* Update docs

Result:

Remove support for Swift 5.6, add 5.10
Copy link
Collaborator

@dnadoba dnadoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lukasa Lukasa added the semver/minor For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 label Oct 4, 2023
@Lukasa
Copy link
Collaborator

Lukasa commented Oct 4, 2023

@swift-server-bot add to allowlist

@Lukasa
Copy link
Collaborator

Lukasa commented Oct 4, 2023

@yim-lee can we remove the 5.6 builder?

@rnro
Copy link
Collaborator Author

rnro commented Oct 4, 2023

@swift-server-bot test this please

@yim-lee
Copy link
Contributor

yim-lee commented Oct 4, 2023

CI updated. @swift-server-bot test this please

@rnro rnro merged commit de7c84a into swift-server:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants